Fix saving large token supplies #201

kespinola · 2024-07-19T13:52:59Z

Issue

Supply is represented as a u64 on the Token but saved in the db as i64 which doesn't support the same number range. The previous code would save these large values as negative which triggers a condition in the API where supply must be > 0 .

An example case is BONK.
https://solana.fm/address/DezXAZ8z7PnrnRJjz3wXBoRgixCa6xjnB7YaB1pPB263/transactions

Changes

Switch DB supply columns on asset and token tables to numeric.
Use decimal in code to represent the numeric type in postgres.

resolves #200

kespinola · 2024-07-23T11:29:29Z

plerkle=> SELECT COUNT(*) FROM asset WHERE supply < 0;
 count
-------
 29508
(1 row)

plerkle=> SELECT COUNT(*) FROM tokens WHERE supply < 0;
 count
-------
 32957
(1 row)

fix: u64 out of range for bigint postgres column type

8eaff39

kespinola requested a review from danenbm July 19, 2024 13:53

danenbm approved these changes Jul 23, 2024

View reviewed changes

kespinola merged commit 20460a2 into metaplex-foundation:main Jul 31, 2024
3 checks passed

kespinola deleted the espi/fix-token-supply branch July 31, 2024 09:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix saving large token supplies #201

Fix saving large token supplies #201

kespinola commented Jul 19, 2024 •

edited

Loading

kespinola commented Jul 23, 2024 •

edited

Loading

Fix saving large token supplies #201

Fix saving large token supplies #201

Conversation

kespinola commented Jul 19, 2024 • edited Loading

Issue

Changes

kespinola commented Jul 23, 2024 • edited Loading

kespinola commented Jul 19, 2024 •

edited

Loading

kespinola commented Jul 23, 2024 •

edited

Loading